[PATCH] BUG: 178658 Adding remote encoding support to Dolphin

Thiago Macieira thiago at kde.org
Tue Mar 24 21:52:19 GMT 2009

rahman duran wrote:
>I have patch for http://bugs.kde.org/show_bug.cgi?id=178658
>Konqueror uses KRemoteEncodingPlugin which is a KParts::Plugin, for
> remote encoding support. I have adapted the code for dolphin; get rid
> off QT3_support and Kparts code and integrated in dolphin.
>With this patch, remote encoding will run as same as it runs in
> Konqueror.
>Please review it if its OK to commit.

Patch looks good, but before you commit, can you fix your indentation 
problems? Please use the same indentation as the rest of Dolphin (Dolphin 
appears to be using 4-space indentation but your new file is doing 2-then-4 
and some braces are in weird positions).

Wasn't there a way to share this code with Konqueror?
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090324/03c9898d/attachment.sig>

More information about the kde-core-devel mailing list