Fwd: KFileDialog combined keyword/filename suggestion

Jonathan Marten jjm2 at keelhaul.demon.co.uk
Fri Mar 13 21:23:12 GMT 2009


David Faure <faure at kde.org> writes:
> On Wednesday 11 March 2009, Jonathan Marten wrote:
>> Albert Astals Cid <aacid at kde.org> writes:
>> > You forgot to attach the patch :D
>> 
>> It's attached to the bug report
>> (https://bugs.kde.org/show_bug.cgi?id=186230).  Follows here too...
>
> No objections from me. (Can't be 100% sure that there are no regressions, of course,
> I don't know that code enough).

Thanks David for your comments.  OK to commit with your suggestions
implemented? - I've run through the test cases and will do so again
with these changes, and since this will only go into trunk any obscure
regressions will not affect the stable branch.

Regards, Jonathan

-- 
Jonathan Marten                         http://www.keelhaul.demon.co.uk
Twickenham, UK                          jjm2 at keelhaul.demon.co.uk




More information about the kde-core-devel mailing list