Fwd: KFileDialog combined keyword/filename suggestion
faure at kde.org
Fri Mar 13 00:29:15 GMT 2009
On Wednesday 11 March 2009, Jonathan Marten wrote:
> Albert Astals Cid <aacid at kde.org> writes:
> > You forgot to attach the patch :D
> It's attached to the bug report
> (https://bugs.kde.org/show_bug.cgi?id=186230). Follows here too...
No objections from me. (Can't be 100% sure that there are no regressions, of course,
I don't know that code enough).
Just one thing that could be simplified:
+ filename = startDir.fileName();
would be more usually done as:
filename = startDir.fileName(); // KUrl::IgnoreTrailingSlash is default anyway
+ KUrl u(url);
I would do u.setPath(u.directory()) instead. Especially since that's exactly what
the if() tests, so it would be more consistent.
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel