KIconLoader::Dialog

[Christoph Feck]

Hi,

I just committed http://websvn.kde.org/?view=rev&revision=986243 to trunk.

Apart from the bug fix, this has also been done to test how applications 
behave when Dialog icon size can be configured (it was fixed to 32 pixels 
before).

The intended use case for the Dialog icons is for icons that do not have text 
beside them, as in icon mode of KPageDialog. If you are unsure, please ask.

So far, KPageDialog respects the icon size, but does not relayout on size 
changes. Please check other applications and report bugs (or even help fixing 
them :)

If during 4.4 cycle it turns out that configurable Dialog icon sizes are too 
troublesome, the code can be disabled again.

There is one problem: Oxygen icon theme currently does not report any 
available icon sizes for the Dialog group. I just use available Desktop icon 
sizes for now. I am not sure who is responsible to decide which sizes are 
available for which group, but maybe artists can work that out. Ideally, I do 
not want any fixed size icon in KDE (as there should be no fixed size font or 
fixed spacings).

Ah, and this commit adds a string "Dialogs", I do not know if any string 
addition should be reported to the translation teams, or if they pick them up 
automatically... note that I have no intention to backport this to 4.3 
branch.

Thanks for any feedback, and happy 4.4 coding :)

Christoph Feck (kdepepo)

Am Saturday 09 May 2009 22:25:47 schrieb Christoph Feck:
> Hi,
>
> Looking at the code to fix bug 153689 (item 3, as 1 and 2 are already
> fixed), I noticed a bug in kdebase/runtime/kcontrol/icons/icons.cpp, namely
> the usage of "KIconLoader::LastGroup".
>
> This file assumes "LastGroup == Panel + 1" (see line 404) without noticing
> that "KIconLoader::Dialog" had been inserted (maybe during KDE 4 port?)
>
> There are two options to fix this bug:
>
> 1) Adding the missing (translatable) string for "Dialog" to the usage combo
> box
>
> 2) work around it (maybe using "X > Panel " instead of "X == LastGroup")
>
> Adding the string would actually add a feature (namely being able to change
> the size of "Dialog" icons), so I am not sure if option 1) is possible
> right now.
>
> Thanks for comments,
> Christoph Feck (kdepepo)
>
> bug link: https://bugs.kde.org/show_bug.cgi?id=153689