Review Request: Add a QSplitter between the places view and the directory tree in KDirSelectDialog

[Raphael Kubo da Costa]

2009/5/25 Raphael Kubo da Costa <kubito at gmail.com>:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/758/
> -----------------------------------------------------------
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Currently, there is no way to resize the places view in a KDirSelectDialog. Sometimes the default width is too small, and I can't see the directory names.
>
> Most of the code in this patch was taken from KFileWidget - a QSplitter is inserted between the places view and the directory tree view, its width is read/written using KConfigGroup and it's not automatically resized when the whole dialog is resized.
>
> The drawback is that modifications to code in KFileWidget may require identical modifications to KDirSelectDialog too. Perhaps the best option would be to refactor this functionality somewhere else, but the work required would be much bigger.
>
>
> Diffs
> -----
>
>  /trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp 972461
>  /trunk/KDE/kdelibs/kfile/kdirselectdialog.h 972461
>
> Diff: http://reviewboard.kde.org/r/758/diff
>
>
> Testing
> -------
>
> Both Ark (in its Extraction Dialog) and Plasma's Desktop Settings (when adding a folder for slideshow wallpapers) now have a QSplitter that works as expected.
>
>
> Thanks,
>
> Raphael
>
>

Hi there,

It's been 8 days since this review request was posted. Has anyone
taken a look at it? Is it OK to commit?

Thanks,
Raphael