Review Request: Stop & Aborted change to Cancel & Canceled in kfind

Jonathan Riddell jr at jriddell.org
Fri Jul 31 18:01:58 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1014/#review1869
-----------------------------------------------------------

Ship it!


Looks good, committed to SVN

- Jonathan


On 2009-07-13 21:31:30, Mackenzie Morgan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1014/
> -----------------------------------------------------------
> 
> (Updated 2009-07-13 21:31:30)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Instead of pressing the Stop button and seeing "Aborted" at the bottom of the window, this patch makes it so that you press the Cancel button and see "Canceled" at the bottom.  Part of Celeste's request for consistency and not using "abort" in user-facing areas https://bugs.launchpad.net/bugs/389751
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/kfind/kfind.cpp 990623 
>   trunk/KDE/kdebase/apps/kfind/kfinddlg.cpp 990623 
>   trunk/KDE/kdebase/apps/kfind/kfindpart.cpp 990623 
> 
> Diff: http://reviewboard.kde.org/r/1014/diff
> 
> 
> Testing
> -------
> 
> Ran it and checked that the right strings were changing.
> 
> 
> Thanks,
> 
> Mackenzie
> 
>





More information about the kde-core-devel mailing list