New authorization library moved to kdereview

[Ingo Klöcker]

On Thursday 23 July 2009, Nicola Gigante wrote:
> On 22/lug/09, at 22:48, Albert Astals Cid wrote:
> > Hi, some comments from my side:
>
> Thank you, I've been waiting for them :D

[snip]

> > * AuthStatus executeAsync(QObject *target = NULL, const char *slot
> > = NULL);
> > in KDE we usually use 0 and not NULL
>
> I'll change it, then. Where's the link where I can find policies like
> this (and possibly the motivation) ?

The 0 vs. NULL issue isn't discussed there, but many other issues:
http://techbase.kde.org/Policies/Library_Code_Policy


> > * You have some  static const ActionReply SuccessReply; i'm not
> > sure if
> > that's ok or you have to use some K_STATIC_FOO macro, can someone
> > clarify it?
>
> I don't know how does that macro work. Anyway I didn't use any
> kdelibs stuff because in the early development days I didn't
> know where it will be included, but now that the final place seems to
> be kdelibs I could use such a macro without problems.

http://techbase.kde.org/Policies/Library_Code_Policy#Static_Objects


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090730/5b39a2d8/attachment.sig>