[PATCH] New KCategorizedView and more changes (kdelibs and kdebase)
sourtooth at gmail.com
Wed Jul 22 13:09:39 BST 2009
> Hi all,
> Finally I have 5 minutes with Internet to type this message...
> I have here a couple patches still unfinished. Still todo:
> * Fix some behavior issues on Dolphin related to Drag & Drop. I suspect that
> the Dolphin view could be buggy. I haven't reviewed it though, I would need
> to have a look.
> * Adapt code at the very end to make everything binary compatible.
> Features and changes:
> * Add a wrap mode to the KFileItemDelegate. This seems to have sense, since
> it can be used for very different purposes. An example is that it can be
> used in dolphin, where we can expect a "line break" in the middle of words,
> for the case that filenames that are actually _long_. On the other hand, we
> also use it on Systemsettings, where we don't want to break in the middle of
> words. Frederik (and the rest), do you think this is OK ?
Ah good, I went looking for a way to do this a short while ago, and
ended up hacking it in... hence the magic numbers.
> * Reconstruct KCategorizedView, with a "blocks" strategy that makes it
> easily to handle and far faster than the old implementation. Also, since it
> is unfinished, is not working right now, but it will be possible to expand
> and collapse categories if the developer wants so.
> * Revert last commit on IconMode.cpp on SystemSettings code, since it uses
> magic numbers, and we can expect its breakage under certain circumstances
> (e.g. very big font sizes, it will have the same width always). No hardcoded
> numbers !!
The System Settings part of the patch looks fine, except for class
definitions and 1 class = 1 file, just to keep things simple. class
bar : public foo - no need for the extra return.
Otherwise please go ahead and commit.
One question - does the drawer now have the seperating line above the
> * Nice looking systemsettings.
> * Nice looking dolphin.
> So I mainly ask for people to try it, and to give technical advice about the
> patch itself. As I say, it is still not finished, and is not BC yet.
> BTW, since this is an "old" patch, it can contain "@since" that are just
> outdated. Ignore them for now...
Please commit as soon as BC issues are fixed.
System Settings Maintainer.
> Best regards and thanks,
> Rafael Fernández López.
More information about the kde-core-devel