Review Request: KFileDialog: Correctly handle slashes when converting filters from Qt

[Felix Geyer]

> On 2009-07-13 19:33:45, Albert Astals Cid wrote:
> > Seems to work here, i'd say you can commit if noone disagrees in a week or so.

Unfortunately I can't as I'm not a KDE developer.


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/934/#review1579
-----------------------------------------------------------


On 2009-07-03 10:17:19, Felix Geyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/934/
> -----------------------------------------------------------
> 
> (Updated 2009-07-03 10:17:19)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fix bug 197195 by escaping slashes ("/" -> "\\/") when converting from Qt filter format.
> This is necessary because KFileDialog treats slashes in the filter as mime types.
> 
> 
> This addresses bug 197195.
>     https://bugs.kde.org/show_bug.cgi?id=197195
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kfile/kfiledialog.cpp 990970 
> 
> Diff: http://reviewboard.kde.org/r/934/diff
> 
> 
> Testing
> -------
> 
> The affected function qt2KdeFilter() is only called in overridden QFileDialog::* calls.
> 
> I tested this with the following code (displayed filter and returned selectedFilter):
> QApplication app(argc, argv);
> QString selectedFilter;
> QFileDialog::getOpenFileName(0, QString(), QString(), "CD/DVD (*.*)", &selectedFilter);
> qDebug() << selectedFilter;
> 
> 
> Thanks,
> 
> Felix
> 
>