[PATCH] konqueror.kcfg missing includes

Mauricio Bahamonde elkrammer at gmail.com
Sat Jul 4 00:33:18 BST 2009


Hi,

kdebase rev 990964 was failing to build for me with the following error:

[ 28% Building CXX object
apps/dolphin/src/CMakeFiles/dolphinprivate.dir/dolphindirlister.o
In file included from
/home/elkrammer/kdesvn/kdebase/apps/konqueror/preloader/preloader.cc:21:
/home/elkrammer/kdesvn/build/kdebase/apps/konqueror/preloader/konqsettingsxt.h:
In static member function ‘static QFont
KonqSettings::defaultStandardFontValue()’:

/home/elkrammer/kdesvn/build/kdebase/apps/konqueror/preloader/konqsettingsxt.h:655:
error: ‘HTML_DEFAULT_VIEW_SANSSERIF_FONT’ was not declared in this scope

/home/elkrammer/kdesvn/build/kdebase/apps/konqueror/preloader/konqsettingsxt.h:
In static member function ‘static int
KonqSettings::defaultMinimumFontSizeValue()’:

/home/elkrammer/kdesvn/build/kdebase/apps/konqueror/preloader/konqsettingsxt.h:711:
error: ‘HTML_DEFAULT_MIN_FONT_SIZE’ was not declared in this scope

/home/elkrammer/kdesvn/build/kdebase/apps/konqueror/preloader/konqsettingsxt.h:
In static member function ‘static int
KonqSettings::defaultSettingsCompletionModeValue()’:

/home/elkrammer/kdesvn/build/kdebase/apps/konqueror/preloader/konqsettingsxt.h:1970:
error: ‘KGlobalSettings’ has not been declared

make[2: ***
[apps/konqueror/preloader/CMakeFiles/kded_konqy_preloader.dir/preloader.o
Error 1
make[1: ***
[apps/konqueror/preloader/CMakeFiles/kded_konqy_preloader.dir/all Error 2

The problem is that the generated konqueror/preloader/konqsettingsxt.h file
is missing two includes:
kglobalsettings.h and khtmldefaults.h

The file konqueror/src/konqsettingsxt.kcfgc has the line:
SourceIncludeFiles=khtmldefaults.h,kglobalsettings.h

which should be taking care of this issue but apparently it is not.

I patched the file konqueror.kcfg directly and this solved the issue,
however i'm not sure if this is a "clean" and elegant way of fixing this
issue. Please advise.

Regards,

-- 
Mauricio Bahamonde.
<elkrammer at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090703/ff5dbde0/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konqueror.kcfg.patch
Type: text/x-patch
Size: 631 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090703/ff5dbde0/attachment.bin>


More information about the kde-core-devel mailing list