Review Request: Make the http kioslave use credentials provided in the url

[Michael Leupold]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/937/
-----------------------------------------------------------

(Updated 2009-07-20 21:36:42.231403)


Review request for kdelibs.


Changes
-------

Patch updated:
As talked about on IRC this one needs no further attributes and just sets the password stored inside the request url empty if using it once failed.


Summary
-------

Currently it's not possible to supply http credentials using the request URL (like http://lemma:mypassword@somewhere.com). I couldn't find any other possibility to "infuse" the credentials without user interaction (which is nice to have in some cases, eg. when doing rpc-over-http).

This patch is currently more a proof of concept. I'm not sure:
- if the credentials should be cached in KPasswdServer if authentication succeeds
- if this is the right way at all. Insights very welcome.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kioslave/http/http.cpp 1000119 

Diff: http://reviewboard.kde.org/r/937/diff


Testing (updated)
-------

Manual tests using kioclient and konqueror indicate it works as (I) expected.


Thanks,

Michael