Review Request: Make the http kioslave use credentials provided in the url
lemma at confuego.org
Thu Jul 9 12:18:40 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
David Faure wrote:
> On Thursday 09 July 2009, Michael Leupold wrote:
>> I haven't found a way to get authentication information into the kio_http
>> other than through direct user input
> Actually, we can also use metadata for that. But yes, if kio_http removes
> the credentials internally (and it should) then putting it into KUrl is
> just fine.
I didn't actually change any client-side part which afaik already strips
credentials and sends it using the setHost() API. What the http kioslave
already does is take this information and use the request url to temporarily
store it (http://websvn.kde.org/trunk/KDE/kdelibs/kioslave/http
/http.cpp?view=diff&r1=832521&r2=832522). It just didn't try to use this
data for authentication.
It seems this will make both credentials in URL as well as credentials set
in config work again.
On a side-note it seems that EnableAutoLogin/autoLoginUser/autoLoginPass
will be passed both using CMD_CONFIG (setConfig()) and CMD_HOST (setHost()).
Should the kioslave just use the ones passed to it in the setHost call or
possibly both (preferring any of them?).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the kde-core-devel