[PATCH] Add support for JEDEC/metric standards to KLocale::formatByteSize

Parker Coates parker.coates at gmail.com
Sat Jul 18 13:54:42 BST 2009


On Fri, Jul 17, 2009 at 17:04, Chusslove Illich wrote:
>> [: Michael Pyne :]
>> I appreciate the feedback provided. My patch is committed more or less
>> unchanged (I had to correct some API documentation minor flaws). [...]
>
> Sorry, only now I got to pay attention to the order of arguments to new
> formatByteSize():
>
>  QString formatByteSize(
>      double size,
>      int precision,
>      BinaryUnitDialect dialect = KLocale::DefaultBinaryDialect,
>      BinarySizeUnits specificUnit = KLocale::DefaultBinaryUnits
>  ) const;
>
> Wouldn't it be more convenient to have the specific unit as third argument?
> Because it seems to me that the need to select that one should be much more
> frequent than to select the binary dialect.

+1




More information about the kde-core-devel mailing list