[PATCH] Add support for JEDEC/metric standards to KLocale::formatByteSize

Chusslove Illich caslav.ilic at gmx.net
Fri Jul 17 22:04:13 BST 2009

> [: Michael Pyne :]
> I appreciate the feedback provided. My patch is committed more or less
> unchanged (I had to correct some API documentation minor flaws). [...]

Sorry, only now I got to pay attention to the order of arguments to new

  QString formatByteSize(
      double size,
      int precision,
      BinaryUnitDialect dialect = KLocale::DefaultBinaryDialect,
      BinarySizeUnits specificUnit = KLocale::DefaultBinaryUnits
  ) const;

Wouldn't it be more convenient to have the specific unit as third argument?
Because it seems to me that the need to select that one should be much more
frequent than to select the binary dialect.

Chusslove Illich (Часлав Илић)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090717/b58b4f89/attachment.sig>

More information about the kde-core-devel mailing list