Review Request: Change "abort session" to "exit session" in kdm

[Celeste Lyn Paul]

> On 2009-07-14 21:14:05, Oswald Buddenhagen wrote:
> > kdmshutdown.cpp:671 & 672 is approved.
> > 
> > the last chunk is negotiable. "exit" sounds weird, as from the user's POV no session was started yet. "cancel" would be technically ok, i guess.
> > 
> > the rest gets a clear reject. think about it. ;-)
> >

Hi Ossi, 

Can you give more details on what you don't like? "Think about it..." is pretty vague.

If I understand you correctly, you don't care about changing the code comments? Or do they not match up with the code and I missed it? If it is because you don't care about the comments, that is fine with me. So for reference changes kdmrc-ref.docbook(539, 1068, 2210) config.def(536, 1233, 1236, 1292, 1809)

You approved changes kdmshutdown.cpp(671, 672). Thanks.

For changes kdmshutdown(709, 711), do you think "Cancel" is a better string than "Exit"? Also, are you saying you think in kgdialog.cpp(72) that "Cancel" would be better than "Exit"? If semantically "Cancel" is closer to the operation since it is in process, then I can agree with "Cancel" instead of the proposed "Exit".


- Celeste Lyn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1013/#review1602
-----------------------------------------------------------


On 2009-07-13 21:28:26, Mackenzie Morgan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1013/
> -----------------------------------------------------------
> 
> (Updated 2009-07-13 21:28:26)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As Celeste noted in https://bugs.launchpad.net/bugs/389751 "abort" isn't very user-friendly.  This patch just changes user-facing instances of "abort" to "exit".  Documentation changes included.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/doc/kdm/kdmrc-ref.docbook 990623 
>   trunk/KDE/kdebase/workspace/kdm/config.def 990623 
>   trunk/KDE/kdebase/workspace/kdm/kfrontend/kdmshutdown.cpp 990623 
>   trunk/KDE/kdebase/workspace/kdm/kfrontend/kgdialog.cpp 990623 
> 
> Diff: http://reviewboard.kde.org/r/1013/diff
> 
> 
> Testing
> -------
> 
> Just string changes.
> 
> 
> Thanks,
> 
> Mackenzie
> 
>