Review Request: Change "abort session" to "exit session" in kdm

Oswald Buddenhagen ossi at kde.org
Tue Jul 14 22:13:59 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1013/#review1602
-----------------------------------------------------------


kdmshutdown.cpp:671 & 672 is approved.

the last chunk is negotiable. "exit" sounds weird, as from the user's POV no session was started yet. "cancel" would be technically ok, i guess.

the rest gets a clear reject. think about it. ;-)


- Oswald


On 2009-07-13 21:28:26, Mackenzie Morgan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1013/
> -----------------------------------------------------------
> 
> (Updated 2009-07-13 21:28:26)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As Celeste noted in https://bugs.launchpad.net/bugs/389751 "abort" isn't very user-friendly.  This patch just changes user-facing instances of "abort" to "exit".  Documentation changes included.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/doc/kdm/kdmrc-ref.docbook 990623 
>   trunk/KDE/kdebase/workspace/kdm/config.def 990623 
>   trunk/KDE/kdebase/workspace/kdm/kfrontend/kdmshutdown.cpp 990623 
>   trunk/KDE/kdebase/workspace/kdm/kfrontend/kgdialog.cpp 990623 
> 
> Diff: http://reviewboard.kde.org/r/1013/diff
> 
> 
> Testing
> -------
> 
> Just string changes.
> 
> 
> Thanks,
> 
> Mackenzie
> 
>





More information about the kde-core-devel mailing list