KColorDialog slot naming

[Albert Astals Cid]

A Divendres, 3 de juliol de 2009, John Tapsell va escriure:
> 2009/7/3 John Tapsell <johnflux at gmail.com>:
> > Hi all,
> >
> >  The API for KColorDialog is somewhat unfortunate.  Currently we have a
> > signal:
> >
> >     void colorSelected( const QColor &col );
> >
> >  Which is emitted immediately when a color is selected.
> >  Qt instead has:
> >
> >     void colorSelected( const QColor &col );
> >     void currentColorSelected( const QColor &col );
> >
> >  Where "currentColorSelected" behaves like our "colorSelected" and
> > "colorSelected" is emitted only once - when the user presses Ok.
>
> Replying to myself..
>
> Would it be reasonable for us to break the current colorSelected
> behavior, and just change it to the way Qt works?  It might break
> previewing in some apps, but it shouldn't break the overall behavior..

No, changing behaviour is in my opinion worse than abi/api breakage, you think 
your code still works because it did work in the past and still compiles but 
at the end it's broken.

Albert

>
> John