KColorDialog slot naming

John Tapsell johnflux at gmail.com
Fri Jul 3 11:19:14 BST 2009


2009/7/3 John Tapsell <johnflux at gmail.com>:
> Hi all,
>
>  The API for KColorDialog is somewhat unfortunate.  Currently we have a signal:
>
>     void colorSelected( const QColor &col );
>
>  Which is emitted immediately when a color is selected.
>  Qt instead has:
>
>     void colorSelected( const QColor &col );
>     void currentColorSelected( const QColor &col );
>
>  Where "currentColorSelected" behaves like our "colorSelected" and
> "colorSelected" is emitted only once - when the user presses Ok.

Replying to myself..

Would it be reasonable for us to break the current colorSelected
behavior, and just change it to the way Qt works?  It might break
previewing in some apps, but it shouldn't break the overall behavior..

John




More information about the kde-core-devel mailing list