[PATCH] new CloseWindow and CloseDocument KStandardGuiItems

[David Faure]

On Friday 16 January 2009, Parker Coates wrote:
> On Fri, Jan 16, 2009 at 12:46, David Faure  wrote:
> > Unless someone here (I'm cc'ing kde-core-devel again) objects to File / Close Window,
> > can you come up with an additional patch for KStandardAction? I'll then commit
> > the changes to kdelibs (trunk) and we'll wait a bit until porting the apps in order to
> > make sure that all developers using trunk get an updated kdelibs first.
> 
> Before you make any decision about "quit" versus "close", I thought
> I'd warn you that there has be a very long and heated discussion of
> this and related topics going on for the last couple weeks on the
> kde-usability list [1].
> 
> You might want to read through some of that (or at least talk to
> Celeste) before changing anything, lest you inadvertently get your
> head torn off. ;D

Indeed. I confused two things though.
The kde-usability discussion is about KStandardShortcuts (Ctrl+W vs Ctrl+Q)
while Marcel's patch is only about buttons in messageboxes, like konqueror's
confirmation dialog mentionned in bug 80981. Thanks for your note, I see
that the standard-shortcut debate is more complex than I thought (and changing
the styleguide is not enough, we need to think about how to define the
right things in KStandardShortcut...). For now I'll commit Marcel's patch
for buttons (GuiItems), it makes sense to me.

-- 
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).