[PATCH] new CloseWindow and CloseDocument KStandardGuiItems

Marcel Partap mpartap at gmx.net
Sat Jan 17 17:52:56 GMT 2009


> I'd warn you that there has be a very long and heated discussion of
>  this and related topics going on for the last couple weeks on the 
> kde-usability list [1].
Uuuuhh no way I am reading all of _that_ thread ;)
I knew some discussion was going on so i wanted to only *add* those
two actions and change them in Konqueror, leaving the policy within 
other apps to the respective app maintainers. But the core of the 
problem is nicely concentrated in the following statement by Jud Craft:
  > Here's the sad truth:  by applying Ctrl-W consistently *every* time
  > (which is a good thing!) based on Application behavior, we actually
  > end up being *inconsistent*...because the *behavior* is what is
  > inconsistent between the Apps.

also, quoting from the kstandardactions implementation makes this 
dilemma even more visible
 > (KAction *quit: Quit the program.)
 > Note that you probably want to connect this action to either
 > QWidget::close() or QApplication::closeAllWindows()

So i didn't change anything in there and provide here just the patch 
to add "Close window" and "Close document" GUI-wise, make Konqui use 
the former one instead of the "Quit" button and leave further steps to 
others more bold than me ;)
rgds marcel

-- 
   "Obstacles are those frightful things you see when you take
    your eyes off your goal."         -- Henry Ford (1863-1947)

    Change the world! Vote: http://hfopi.org/vote-future

-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-close-document-action-icons.tar.gz
Type: application/gzip
Size: 9345 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090117/05d7dc0f/attachment.gz>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kstandardguiitem-add-closewindow-and-closedocument.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090117/05d7dc0f/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: konqueror-change-close-button.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090117/05d7dc0f/attachment-0001.ksh>


More information about the kde-core-devel mailing list