Overwriting default menu entry locations (was: Re: KDE/kdelibs/kdeui/xmlgui)

[David Faure]

On Sunday 18 January 2009, Friedrich W. H. Kossebau wrote:
> > I'm not entirely confident about backporting it, so close to 4.2..... hmm,
> > OTOH empty menus really look bad... can you all test your app's xmlgui with
> > kdelibs trunk this weekend? If no regressions are found I'll backport on
> > Monday.
> 
> I would say if you are unsure you could even wait until the tagging of 4.2.0. 
> This error (empty menu) hasn't been triggered before, and to trigger it one 
> must explicitely add a noMerge=1 menu with no or only unimplemented action 
> ids. Nothing one would accidently do, or? :)

In fact it happens more than one might think. I won't backport because
it caused a crash in trunk: okular would crash on startup because of this change.
It used to call toolBarMenuAction() with an empty toolbar created by the
okular shell, and then later on would load a part that would fill the toolbar.
With my change it would not find any toolbar initially and therefore no
toolbar-action would be created. Turns out okular didn't need to get hold
of that action at all anyway, so this is fixed, but the behavior difference tells
me I shouldn't backport this at this point :-)

-- 
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).