[PATCH] New image loader (Softimage PIC)

Ruben Lopez r.lopez at bren.es
Mon Dec 28 11:27:40 GMT 2009

Ok, here it is the new patch. It patches the original (unpatched) 
kdelibs-4.3.4, and has the following changes:

- Adapted all the if's to have the body in other line and always with 
- Changed all the includes for QImage

Is it ready to be included in the next kdelibs version?


Ruben Lopez wrote:
> Esben Mose Hansen wrote:
>> On Friday 18 December 2009 22:06:12 David Faure wrote:
>>> Not much to say about the image loader itself (except that it could
>>> follow the kdelibs coding style a bit more, especially the if+return in
>>> one line hurts readability given that we're not used to that).
>> More than just readability, it is hard to set breakpoints in 
>> constructs like that. That is why I always suggest a newline before 
>> the block in if, even if it is just one short line.
>> (We don't really do that here, but always using {} in if blocks is 
>> also a good idea, in my not-so-humble opinion).
> Sorry for the delay, I was on holidays. I agree both of you. I will 
> send a new patch when this is changed and tested.
> About the pic extension bound to hdr image type, it has been in KDE 
> for years, and I don't really know why. Maybe some digital camera uses 
> pic extension also for its hdr format? Anyway, the Softimage pic 
> loader and mime info are smart enough to discard any file that does 
> not have the right magic numbers in the header (the hdr mime type is 
> not), so having it with higher priority should solve the conflict in 
> all cases.
> Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-4.3.4-bren2.patch
Type: text/x-patch
Size: 28550 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091228/1b2ad430/attachment.bin>

More information about the kde-core-devel mailing list