Review Request: Fix cookie expiration date parsing in KCookieJar...

adawit at adawit at
Fri Dec 18 19:13:40 GMT 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-12-18 19:13:40.643867)

Review request for kdelibs.


Avoid code duplication...


This patch addresses the issue of parsing cookie expiration date correctly. Failing to parse expiration dates properly results in the cookie being treated as a session cookie which results in many unintended side effects similar to those reported in the bug reports listed above.

This addresses bugs 145244, 176731, 187792, and 191318.

Diffs (updated)

  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h 1063537 
  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp 1063537 
  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/tests/cookie.test 1063537 



* kcookiejar unit test.
* Spot check with few sites that set cookies based on a "remember me" option.



More information about the kde-core-devel mailing list