Review Request: Fix cookie expiration date parsing in KCookieJar...

[adawit at kde.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2404/
-----------------------------------------------------------

(Updated 2009-12-18 19:13:40.643867)


Review request for kdelibs.


Changes
-------

Avoid code duplication...


Summary
-------

This patch addresses the issue of parsing cookie expiration date correctly. Failing to parse expiration dates properly results in the cookie being treated as a session cookie which results in many unintended side effects similar to those reported in the bug reports listed above.


This addresses bugs 145244, 176731, 187792, and 191318.
    https://bugs.kde.org/show_bug.cgi?id=145244
    https://bugs.kde.org/show_bug.cgi?id=176731
    https://bugs.kde.org/show_bug.cgi?id=187792
    https://bugs.kde.org/show_bug.cgi?id=191318


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h 1063537 
  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp 1063537 
  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/tests/cookie.test 1063537 

Diff: http://reviewboard.kde.org/r/2404/diff


Testing
-------

* kcookiejar unit test.
* Spot check with few sites that set cookies based on a "remember me" option.


Thanks,

adawit