Review Request: Fix cookie expiration date parsing in KCookieJar...

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2404/#review3450
-----------------------------------------------------------



/trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp
<http://reviewboard.kde.org/r/2404/#comment2761>

    This logic is duplicated in 3 places, is there a way to make a helper method for it?
    Maybe cookie.isExpired() (no arguments) could take care of comparing with the current datetime?


- David


On 2009-12-18 00:05:33, adawit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2404/
> -----------------------------------------------------------
> 
> (Updated 2009-12-18 00:05:33)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch addresses the issue of parsing cookie expiration date correctly. Failing to parse expiration dates properly results in the cookie being treated as a session cookie which results in many unintended side effects similar to those reported in the bug reports listed above.
> 
> 
> This addresses bugs 145244, 176731, 187792, and 191318.
>     https://bugs.kde.org/show_bug.cgi?id=145244
>     https://bugs.kde.org/show_bug.cgi?id=176731
>     https://bugs.kde.org/show_bug.cgi?id=187792
>     https://bugs.kde.org/show_bug.cgi?id=191318
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp 1063375 
>   /trunk/KDE/kdelibs/kioslave/http/kcookiejar/tests/cookie.test 1063374 
> 
> Diff: http://reviewboard.kde.org/r/2404/diff
> 
> 
> Testing
> -------
> 
> * kcookiejar unit test.
> * Spot check with few sites that set cookies based on a "remember me" option.
> 
> 
> Thanks,
> 
> adawit
> 
>