KDE Trunk based on Qt 4.6

[Albert Astals Cid]

A Diumenge, 30 d'agost de 2009, Benjamin Meyer va escriure:
> On Aug 30, 2009, at 12:14 PM, Christoph Feck wrote:
> > Am Sunday 30 August 2009 17:13:14 schrieb Thiago Macieira:
> >> Em Domingo 30. Agosto 2009, às 16.49.55, Christoph Feck escreveu:
> >>> Ideally, I would just svn commit to qt-copy with a fix, add a BUG:
> >>> or a
> >>> QTISSUE: number, and request merging with upstream Qt using a
> >>> QTMERGE
> >>> tag. Done. It cannot get simpler. Post-commit review works.
> >>
> >> That's exactly what we're asking of you.
> >>
> >> Create the fix, commit it, push to Gitorious, then create an MR
> >> saying
> >> "here, I fixed the issue".
> >
> > No. Browsing KDE/Qt sources in the editor. Find a bug. Correct that.
> > Hit save.
> > Want to commit.
> >
> > For KDE sources I have to:
> >
> > 0. "svn up/diff" to be sure
> > 1. "svn commit" with BUG: number
> > 2. "svnbackport" if I want it in stable branch
> > 3. go back to editor to look for the next file I could fix
>
> And then I revert your commit because it broke something that would
> have been caught if you had bother to ask for a review from the guy
> who maintains the code.

That's both rude and off topic.

Albert

>
> -Benjamin Meyer