Review Request: Jpeg thumbnailer honouring jpeg rotation info

Jacopo De Simoi wilderkde at
Sun Aug 30 11:54:10 BST 2009

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


This patch makes the jpeg thumbnailer honor jpeg rotation infos stored in exif metadata. 
The method is quite simple, although I don't like ifdefs, this time they seem to me to be necessary.
It's my first nontrivial CMake modification; please check that I did not do something stupid there.
Also, the orientationMatrix method could be ifdeffed if you feel it is necessary; I just didn't want to add another ifdef.

I am not sure if this is a good solution performance-wise; please comment on that if you have better ideas.


  branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1016603 
  branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/jpegcreator.h 1016603 
  branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/jpegcreator.cpp 1016603 



Works good with a *clean* .thumbnails directory. Cached thumbnails are indeed a problem; not sure how to solve this issue yet.


Dolphin showing correctly rotated jpegs



More information about the kde-core-devel mailing list