Review Request: KWindowSystemEventFilter: methods for installing global event filters

Michael Leupold lemma at
Sat Aug 22 23:39:00 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-08-22 22:38:59.975234)

Review request for kdelibs.


Make it ready for review...

Summary (updated)

This patch moves the installX11EventFilter functionality from inside KApplication to an external KWindowSystemEventFilter namespace. Like this, non-KApplications can use global event filters (and KApplication gets smaller).

The new methods use QAbstractEventDispatcher and are named KWindowSystemEventFilter::installEventFilter and removeEventFilter. They are not meant to be specific to X11 any longer but the current implementation is only concerned with X11 as I don't have another window system to test it with (I provided stubs that could serve as base for an implementation).

Diffs (updated)

  /trunk/KDE/kdelibs/kdeui/kernel/kwindowsystemeventfilter.h PRE-CREATION 
  /trunk/KDE/kdelibs/kdeui/kernel/kwindowsystemeventfilter.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/kdeui/kernel/kapplication.cpp 1013867 
  /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1013867 
  /trunk/KDE/kdelibs/kdeui/kernel/kapplication.h 1013867 


Testing (updated)

Too little I fear. I tested it with KColorDialog which uses KApplication::installX11EventFilter for its color picker and it worked fine.

There should be a unit-test for it but I haven't thought of any.



More information about the kde-core-devel mailing list