kio_sftp rewrite

[Ben Boeckel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dawit A. wrote:

> On Friday 07 August 2009 04:17:07 Andreas Schneider wrote:
>> On Wednesday 05 August 2009 15:39:07 Andreas Schneider wrote:
>> > I have a patch of my current work for KDE 4.3. You can find 
it here:
>> >
>> > http://reviewboard.kde.org/r/1226/
>>
>> Hi,
>>
>> I have my KDE SVN account now. I could commit it but it would 
be nice if
>> someone could look over it before I commit it.
>>
>> If you want to test it, install the kioslave and then call 
'kdeinit4'.
>>
>>
>> Cheers,
>>
>> -- andreas
> 
> Well if you have a screwed up ssh server that refuses 
connection like I do
> right now, then kio_sftp with your changes SEGFAULTS and I 
think I know
> why... There is a code that does the following in 
openConnection:
> 
>   sftp_session = sftp_new(ssh_session);
>   if (sftp_session == NULL) {
>     closeConnection();
>     return;
>   }
> 
> but unfortunately, closeConnection also does...
> 
>   sftp_free(sftp_session);
>   sftp_session = NULL;
> 
> so if sftp_session is already NULL as in the above case, then 
the ioslave
> goes down in flames. Once I get around to fixing my ssh 
server, I will
> test basic functionality and let you know, but I think it 
should be fine
> to commit this into the main tree on work on improving it from 
there, no ?

free() (and delete) should not crash on NULL and neither should 
similar functions. It should be a noop I'm pretty sure. IMO, 
this is a bug in sftp_free.

- --Ben
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkp/mMwACgkQiPi+MRHG3qQdeQCdEAEgw8EPJjUxY7xT//y3L5rH
FPoAnAmyP9dchWdREuRPnXxwL3fv1r9G
=imWy
-----END PGP SIGNATURE-----