[PATCH] kdirwatch problem of detecting hard link change

[sycao]

Pau Garcia i Quiles wrote:
> On Fri, Aug 7, 2009 at 7:23 AM, sycao<sycao at redflag-linux.com>  wrote:
>    
>> sonald wrote:
>>      
>>>   the problem comes up  when  I  traced the problem when using kcmshell4
>>> clock
>>>   to set timezone, which is when you changed timezone second time,
>>>   the setting just lost. I found the real problem is that
>>>   KDirWatch loses watch on /etc/localtime.
>>>
>>>   I can reproduce the watch lose very easily:
>>>     # inotifywait -m /etc/localtime
>>>     # zic -l Asia/Shanghai
>>>     # zic -l Asia/Muscat
>>>     # touch /etc/localtime
>>>
>>>   After Change timezone to Muscat, subsequent changes to /etc/localtime
>>>   won't be watched. because KDirWatch use inotify (I'm using a linux
>>> distro),
>>>   which monitoring file with respect to inode , not dir entry.
>>>   zic relinked ( hardlink ) /etc/localtime, so inotify just told attrib
>>>   change ( st_nlink change ) of the original file.
>>>
>>>   I post the patch a few months ago, and it seems that problem still exists
>>>   int KDE 4.3 RC, so I post here to see if it can make some help.
>>>
>>>   Sian Cao
>>>
>>>
>>>
>>>        
>> Hi, all
>>   I sent this patch for a long time, and no one review it yet. but this is
>> really a problem.
>>
>> Sian Cao
>>      
>
> Sorry, I didn't answer. I tested it at aKademy on my Ubuntu Hardy
> (kernel 2.6.24-23-generic) and it did not work for me.
>
> Fixing this bug would probably fix bug 196316 "kcmdatetimehelper does
> not set time zone correctly"
>
>    
Yes,  kdirwatch is responsible for this bug partially, which causes 
timezone daemon
tracking /etc/localtime effectively,  and I have been trying to fix 
kcontrol/dateandtime
to make a whole solution.

Sian Cao
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090807/581ab9c3/attachment.htm>