KCategorizedView BC

[Olivier Goffart]

Le Wednesday 05 August 2009, Rafael Fernández López a écrit :
> Hi all,
>
> After having reviewed the issue reported that KCategorizedView is not BC
> with the old version, I can just say that I haven't found any problems of
> binary compatibility.
>
> If someone else wants to have a look, I would be more than pleased.


Could be the new reimplementation of rowsAboutToBeRemoved

Remember that it might not be called for derived class compiled with the old 
version. (Their old virtual table contains the symbol of the QAbstractItemView 
one, and the derived class reimplementation might call dirrectly one from 
QAbstractItemView)  

If this is the case, making it a slot might solve half of the problem.
Making a new slot connected the the right signal should solve the problem)

-- 
Olivier

>
>
> Regards,
> Rafael Fernández López.
>
> PS1: reordering virtual methods in KCategorizedView that are reimplemented
> from QAbstractItemView/QListView is _not_ an issue. The vtable entries are
> set up by the classes on the top, this is QAbstractItemView, what does not
> affect the BC of KCategorizedView, since we are already accessing to
> entries that are ordered in a binary compatible way.
>
> PS2: I haven't tried to compile with the old KCategorizedView, for
> instance, kdebase, recompile the new kdelibs and see if all works (a.k.a, a
> practical BC check).
>
>
> Regards,
> Rafael Fernández López.