Review Request: Rewrite of KLocale::readTime() and KLocale::formatTime()

Michael Leupold lemma at
Sun Aug 2 11:17:04 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-08-02 10:17:03.625767)

Review request for kdelibs.


Just a short update: "sg" locale time format is now correct and doesn't need to be excluded from the unit-test.

Who do I have to bug to get this patch reviewed?


While working on a QValidator for time entry I found KLocale::readTime() and KLocale::formatTime() to be somewhat lacking in certain areas:
- stripping of AM/PM ("%p") doesn't work for all locales
- if I don't want AM/PM I need to format as a duration (which means it will be 24h) which is inconvenient in cases where the AM/PM is "external" (eg. inside a combobox to choose from). Not having to mod 12 the hours beforehand seems more convenient.
- checking is always strict. As the method reads user input there should be a way to make it operate in lax mode (ie. ignoreing missing or additional spaces in user input)
- readTime() has less features than formatTime (no am/pm stripping or durations).
- signatures for readTime() and formatTime() could be adapted to match each other somewhat.

I tried to achieve all of the above with a partial rewrite of those methods using the old code and some code I wrote while developing the validator. I also wrote an additional testcase for reading/formatting times.

Diffs (updated)

  /trunk/KDE/kdelibs/kdecore/localization/klocale.h 1004497 
  /trunk/KDE/kdelibs/kdecore/localization/klocale.cpp 1004497 
  /trunk/KDE/kdelibs/kdecore/tests/CMakeLists.txt 1004497 
  /trunk/KDE/kdelibs/kdecore/tests/klocaletest.cpp 1004497 
  /trunk/KDE/kdelibs/kdecore/tests/klocaletimeformattest.h PRE-CREATION 
  /trunk/KDE/kdelibs/kdecore/tests/klocaletimeformattest.cpp PRE-CREATION 



klocaletest succeeds, the new testcase succeeds as well.



More information about the kde-core-devel mailing list