Review Request: Make it configurable if "folders are always first" in KDirSortFilterProxyModel

Peter Penz peter.penz at gmx.at
Wed Apr 15 08:51:22 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/585/#review925
-----------------------------------------------------------


As discussed already: From my point of view it is OK to commit this patch next Monday.

- Peter


On 2009-04-14 11:59:29, Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/585/
> -----------------------------------------------------------
> 
> (Updated 2009-04-14 11:59:29)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> I propose a change to KDirSortFilterProxyModel: Right now, files and folders are sorted separately (such that folders are always first in the sorted data). I propose to make this configurable.
> 
> Dolphin could use this to let the user choose if folders are always shown first or not. That has been reported a couple of times as a wish on bugs.kde.org, and it was actually possible in Konqueror 3's Icons View. I've discussed this with Peter Penz already and sent him a patch for Dolphin (and the DolphinPart).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kdirsortfilterproxymodel.h 953885 
>   /trunk/KDE/kdelibs/kfile/kdirsortfilterproxymodel.cpp 953885 
> 
> Diff: http://reviewboard.kde.org/r/585/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frank
> 
>





More information about the kde-core-devel mailing list