Review Request: SystemTrayIcon behavior not consistent with taskbar in some circumstances

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/579/#review929
-----------------------------------------------------------


i think it can be slightly simplified, and while i can see where this can go wrong none of the apps i have in my tray exhibit this bug? what application(s) are you using to demonstrate the problem?


/trunk/KDE/kdelibs/kdeui/util/ksystemtrayicon.cpp
<http://reviewboard.kde.org/r/579/#comment619>

    just call minimizeRestore(true) and then return?


- Aaron


On 2009-04-13 01:35:25, Mathieu Seigneurin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/579/
> -----------------------------------------------------------
> 
> (Updated 2009-04-13 01:35:25)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> Right now on kde-4.2.2 a dummy application that uses plain KSystemTrayIcon has
> the following behavior:
> - app show on current desktop, not obscured
>   - click on taskbar entry => minimize to taskbar
>   - click on system tray => minimize to tray
> - app on current desktop, obscured
>   - click on taskbar entry => raise, focus
>   - click on system tray => raise, focus
> - app hidden in systray, not showing or minimized anywhere
>   - click on systray => show, raise, focus on current desktop
> - app shown on other desktop, minimized:
>   - click on taskbar entry => move user to app's desktop
>   - click on systray => move user to app's desktop
> All this is fine and consistent
> 
> But:
> - app shown on other desktop, NOT minimized:
>   - click on taskbar entry => move to app's desktop, un-minimize raise focus
>   - click on systray => hide app in systray
> 
> This last behavior is a bit surprising and is the only inconsistency I can find
> between taskbar and systray handling (appart from the very first point which is
> obviously what is expected).
> 
> Additionaly, there is a bug in the systray handling with regards to windows
> showing on all desktops. If that setting is changed between hide/restores from
> tray, the cached d->onAllDesktops can be stale. This patch should fix that too.
> 
> Thanks for reading!
> 
> 
> This addresses bugs 74938 and 188866.
>     https://bugs.kde.org/show_bug.cgi?id=74938
>     https://bugs.kde.org/show_bug.cgi?id=188866
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/util/ksystemtrayicon.cpp 951942 
> 
> Diff: http://reviewboard.kde.org/r/579/diff
> 
> 
> Testing
> -------
> 
> I think I tested all the combinations of minimize/hide/restore/desktop dance,
> but some might well have slipped by...
> 
> 
> Thanks,
> 
> Mathieu
> 
>