Review Request: Use kpasswdserver's new async requests
Aaron Seigo
aseigo at kde.org
Tue Apr 14 20:59:36 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/551/#review919
-----------------------------------------------------------
Ship it!
looks good; nice, clean and the dbus information is kept to one side now...
- Aaron
On 2009-04-14 12:52:04, Michael Leupold wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/551/
> -----------------------------------------------------------
>
> (Updated 2009-04-14 12:52:04)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> kdelibs part of my patch:
> - add D-Bus metatypes for KIO::AuthInfo - needed by the kpasswdserver patch (should compile without though)
> - make KIO::SlaveBase use the new calls, but provide fallback if someone is running with an old kpasswdserver
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kio/CMakeLists.txt 949887
> /trunk/KDE/kdelibs/kio/kio/authinfo.h 949887
> /trunk/KDE/kdelibs/kio/kio/authinfo.cpp 949887
> /trunk/KDE/kdelibs/kio/kio/kpasswdserver.cpp PRE-CREATION
> /trunk/KDE/kdelibs/kio/kio/kpasswdserver_p.h PRE-CREATION
> /trunk/KDE/kdelibs/kio/kio/kpasswdserverloop.cpp PRE-CREATION
> /trunk/KDE/kdelibs/kio/kio/kpasswdserverloop_p.h PRE-CREATION
> /trunk/KDE/kdelibs/kio/kio/org.kde.KPasswdServer.xml PRE-CREATION
> /trunk/KDE/kdelibs/kio/kio/slavebase.cpp 949887
>
> Diff: http://reviewboard.kde.org/r/551/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael
>
>
More information about the kde-core-devel
mailing list