Review Request: Use kpasswdserver's new async requests

Michael Leupold lemma at
Tue Apr 14 12:49:08 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-04-14 04:49:08.078240)

Review request for kdelibs.


Major overhaul of the patch. Major changes:
* Added a KPasswdServer API - it's private API but if needed it could become a public one
* as a result SlaveBase gets cleaner. All the handling of kpasswdservers which don't support the new API (mainly meant for developers during the 4.3 release cycle) is stripped away into this new class.
* Added handling for non QCoreApplication kioslaves (the new API uses a QEventLoop which they can't handle - use the old D-Bus calls instead)

KPasswdServer still uses the old service name (org.kde.kded) instead of a specific one (kpasswdserver now additionally registers org.kde.kpasswdserver). This is transitional because I didn't want to add 2 D-Bus interfaces to the class. Once we're pretty sure everyone's kdebase is up-to-date we can change that to the new service name.


kdelibs part of my patch:
- add D-Bus metatypes for KIO::AuthInfo - needed by the kpasswdserver patch (should compile without though)
- make KIO::SlaveBase use the new calls, but provide fallback if someone is running with an old kpasswdserver

Diffs (updated)

  /dev/null 949887 
  /dev/null 949887 
  /dev/null 949887 
  /dev/null 949887 
  /dev/null 949887 
  /trunk/KDE/kdelibs/kio/CMakeLists.txt 949887 
  /trunk/KDE/kdelibs/kio/kio/authinfo.h 949887 
  /trunk/KDE/kdelibs/kio/kio/authinfo.cpp 949887 
  /trunk/KDE/kdelibs/kio/kio/slavebase.cpp 949887 





More information about the kde-core-devel mailing list