Review Request: Use kpasswdserver's new async requests

[Michael Leupold]

> On 2009-04-12 06:05:12, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/kio/kio/slavebase.cpp, lines 75-77
> > <http://reviewboard.kde.org/r/551/diff/1/?file=5151#file5151line75>
> >
> >     this is duplicated in your patch to kdebase/runtime .. could it be harmonized between the two files, e.g. by making a trio of static const char* (or QString?) methods in the public API?
> >     
> >     seems less brittle that way to me ...

There currently is no public API :-) And I'm not sure it makes sense to have one because I understand it kpasswdserver is meant to be used only by kioslaves.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/551/#review906
-----------------------------------------------------------


On 2009-04-10 01:49:12, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/551/
> -----------------------------------------------------------
> 
> (Updated 2009-04-10 01:49:12)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> kdelibs part of my patch:
> - add D-Bus metatypes for KIO::AuthInfo - needed by the kpasswdserver patch (should compile without though)
> - make KIO::SlaveBase use the new calls, but provide fallback if someone is running with an old kpasswdserver
> 
> 
> Diffs
> -----
> 
>   /dev/null 949887 
>   /dev/null 949887 
>   /trunk/KDE/kdelibs/kio/CMakeLists.txt 949887 
>   /trunk/KDE/kdelibs/kio/kio/authinfo.h 949887 
>   /trunk/KDE/kdelibs/kio/kio/authinfo.cpp 949887 
>   /trunk/KDE/kdelibs/kio/kio/slavebase.cpp 949887 
> 
> Diff: http://reviewboard.kde.org/r/551/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>