Review Request: Add async requests to kpasswdserver

[Oswald Buddenhagen]

> On 2009-04-12 05:55:18, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h, lines 34-36
> > <http://reviewboard.kde.org/r/550/diff/1/?file=5144#file5144line34>
> >
> >     #defines .. ew :)
> >     
> >     perhaps consider using static const char*?

#defines are the compiler-wise cheapest possible way to reach the goal and are well-understood when used properly (like in this case).
and the "c++-clean" alternative would be static const char FOO[] (if you insist on wasting a pointer, then make it static const char * const FOO). what is the correct capitalization for non-#define constants, anyway?


- Oswald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/550/#review905
-----------------------------------------------------------


On 2009-04-10 01:46:47, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/550/
> -----------------------------------------------------------
> 
> (Updated 2009-04-10 01:46:47)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch adds async requests to kpasswdserver. It adds checkAuthInfoAsync and queryAuthInfoAsync as well as appropriate signals to return the results back to the client.
> 
> The goal is to not have requests sent from kioslaves time-out in the future.
> 
> This patch depends on a patch to kdelibs which I'll post in a minute.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h 948864 
>   /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp 948864 
> 
> Diff: http://reviewboard.kde.org/r/550/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>