Review Request: Add async requests to kpasswdserver

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/550/#review905
-----------------------------------------------------------



/trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h
<http://reviewboard.kde.org/r/550/#comment583>

    #defines .. ew :)
    
    perhaps consider using static const char*?



/trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h
<http://reviewboard.kde.org/r/550/#comment582>

    KPASSWDSERVER_INTERFACE?



/trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h
<http://reviewboard.kde.org/r/550/#comment581>

    does this really need to be in this file? could it be an auto-generated xml file using qdbuscpp2xml? the reason for that is putting the xml directly in the file this way is very fragile: you have to remember to modify the xml (and do it properly..) whenever / if ever the class is modified.



/trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp
<http://reviewboard.kde.org/r/550/#comment584>

    qDeleteAll(m_authPending);



/trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp
<http://reviewboard.kde.org/r/550/#comment585>

    qDeleteAll(m_authWait);


- Aaron


On 2009-04-10 01:46:47, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/550/
> -----------------------------------------------------------
> 
> (Updated 2009-04-10 01:46:47)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch adds async requests to kpasswdserver. It adds checkAuthInfoAsync and queryAuthInfoAsync as well as appropriate signals to return the results back to the client.
> 
> The goal is to not have requests sent from kioslaves time-out in the future.
> 
> This patch depends on a patch to kdelibs which I'll post in a minute.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h 948864 
>   /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp 948864 
> 
> Diff: http://reviewboard.kde.org/r/550/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>