Review Request: allow PYTHON_SITE_PACKAGES_DIR be set from cmake's command line

Thiago Macieira thiago at kde.org
Sat Apr 11 20:46:30 BST 2009


Marcos Dione wrote:
>    I could complicate it a bit, at least for a first shot. still not
>trying to do all the magic in [1], I could make it install in:
>
>    * python's site-packages.
>    * your proposed path, except for the PyKDE4 part (this also applies
>to plasma stuff).
>    * the one specified using -DPYTHON_SITE_PACKAGES_DIR.
>
>    we could make the first the default, making the work of packagers
>easier, and enabling the second with something like
>-DPYTHON_LIBS_WITH_KDE_LIBS. or we could make the second the default,
>more obvious for those setting the CMAKE_PREFIX_DIR and specting it to
>be honored by the whole install process, and enabling the fisrt with
>-DPYTHON_LIBS_IN_PYTHON_SITE_PACKAGES. and the third as told. all this
>with the proper doc somewhere in kdelibs, kdebase and kdebindings; the
>latter two the only (as of today) affected modules.

Please do that without modifying FindPythonLibraries.cmake. You can choose 
a different name for the variable instead of reusing the one from the 
script.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090411/d8c1c144/attachment.sig>


More information about the kde-core-devel mailing list