[PATCH] Support for title in notifications

Aurélien Gâteau aurelien.gateau at canonical.com
Tue Apr 7 16:51:25 BST 2009


Hi,

Right now, the notifications implemented by Plasma can display a text
and an optional title. Unfortunately, it is not possible to define a
custom title with KNotification (it's possible with kdialog, though,
because it talks to Plasma directly)

There is some discussion going on on freedesktop xdg ml about getting
Galago and KDE notifications to agree on a common spec. Adding support
for title is imho a necessary step in this direction.

The attached patches add the "title" property to KNotification and all
the necessary plumbing. The change to KNotification is BC I think, but I
had to change the prototype of the DBus calls between
KNotificationManager and knotify4. I believe these DBus calls can be
considered internal. Is this OK?

I also attach a simple Kopete patch which illustrate the change, using
the contact name as a title.

Since today is soft-freeze, I guess it's the last time this can go in
for KDE 4.3.

Aurélien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: title-in-notifications-kdebase.diff
Type: text/x-diff
Size: 6036 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090407/393e67d2/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: title-in-notifications-kdelibs.diff
Type: text/x-diff
Size: 3153 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090407/393e67d2/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kopete-use-setTitle.diff
Type: text/x-diff
Size: 1496 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090407/393e67d2/attachment-0002.diff>


More information about the kde-core-devel mailing list