[PATCH] Support for title in notifications

[Olivier Goffart]

Le Tirsdag 7 april 2009, Aurélien Gâteau a écrit :
> Hi,
>
> Right now, the notifications implemented by Plasma can display a text
> and an optional title. Unfortunately, it is not possible to define a
> custom title with KNotification (it's possible with kdialog, though,
> because it talks to Plasma directly)
>
> There is some discussion going on on freedesktop xdg ml about getting
> Galago and KDE notifications to agree on a common spec. Adding support
> for title is imho a necessary step in this direction.

Ok, but we need to define what the title is for

>
> The attached patches add the "title" property to KNotification and all
> the necessary plumbing. The change to KNotification is BC I think, but I
> had to change the prototype of the DBus calls between
> KNotificationManager and knotify4. I believe these DBus calls can be
> considered internal. Is this OK?

No, DBus calls are not internals.
That makes an old application not working with the now knotify4
The old call need to be kept for compatibility.

> I also attach a simple Kopete patch which illustrate the change, using
> the contact name as a title.

Well, this is just an illustration, but IMO, the titre should be more 
something allongs the lines of "new message"    or "new message from ...."

Currently i think plasma display "Notification from Kopete" as a title which 
is not that bad.

Another solution is to store the title in the .notifyrc  file.

>
> Since today is soft-freeze, I guess it's the last time this can go in
> for KDE 4.3.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090407/65217bc8/attachment.sig>