[PATCH] Take care also of the KJob::finished signal in KPart - it also fixes Ark's BUG 187538

Alessandro Diaferia alediaferia at gmail.com
Tue Apr 7 09:38:50 BST 2009

2009/4/7 Kevin Ottens <ervin at kde.org>

> On Tuesday 7 April 2009 09:57:25 Alessandro Diaferia wrote:
> > What about adding a new killed() signal to KJob? It should be emitted
> > whenever the job is killed which does not mean that an error occured,
> just
> > that someone killed the job. This way application can still behave well i
> > suppose.
> That's basically what you get if you connect to finished(KJob*) and test
> the
> error code there. No need for an extra signal which does the same thing,
> even
> if I discourage the use of this signal for other purposes than job
> trackers.
> Adding yet another signal with a slightly different semantic would just add
> to
> my headaches. :-)

Lol, ok.. I'd commit then but i think that the _k_slotJobFinished slot would
be useful also in this case.. But since we are discouraged to use the
finished() signal i dunno how to connect to that slot :)

> Regards.
> --
> Kévin 'ervin' Ottens, http://ervin.ipsquad.net
> "Ni le maître sans disciple, Ni le disciple sans maître,
> Ne font reculer l'ignorance."

Alessandro Diaferia
KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090407/dd9ef188/attachment.htm>

More information about the kde-core-devel mailing list