[PATCH] Take care also of the KJob::finished signal in KPart - it also fixes Ark's BUG 187538

Kevin Ottens ervin at kde.org
Tue Apr 7 09:18:07 BST 2009

On Tuesday 7 April 2009 09:57:25 Alessandro Diaferia wrote:
> What about adding a new killed() signal to KJob? It should be emitted
> whenever the job is killed which does not mean that an error occured, just
> that someone killed the job. This way application can still behave well i
> suppose.

That's basically what you get if you connect to finished(KJob*) and test the 
error code there. No need for an extra signal which does the same thing, even 
if I discourage the use of this signal for other purposes than job trackers. 
Adding yet another signal with a slightly different semantic would just add to 
my headaches. :-)

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090407/d9c8a1f1/attachment.sig>

More information about the kde-core-devel mailing list