Exherbo patch for kdelibs
neundorf at kde.org
Thu Apr 2 22:28:50 BST 2009
On Wednesday 01 April 2009, Ingmar Vanhassel wrote:
> It does, but it could do it even better. ;-) Ideally there would be a
> way for us to turn autodetection off, when we don't want a particular
> optional dependency enabled *and* a way to have autodetection find
> libfoo.so as optional dependency, but fail, if it doesn't find it.
> If I want to explicitly enable an optional feature, then for me it's an
> error if that feature can't be enabled due to a dependency not being
> found. The cmake step should signal that & abort, instead of disabling
> the features. Is there a way to change that? (Without passing in the
> path to every library.)
> Any pointers to implementing that, in case it's not there yet?
This would mean that a REQUIRED would have to be added to the FIND_PACKAGE()
call. This could be done inside the MACRO_OPTIONAL_FIND_PACKAGE() macro,
depending e.g. on an OPTION() defined in MacroOptionalFindPackage.cmake.
> > Beside that, I have no objections to the patch.
> > Alex
> Could you commit it for us? None of the Exherbo KDE maintainers have
> commit access.
More information about the kde-core-devel