Shortcut Scheme support and a todo for all applications

[Andreas Pakulat]

On 29.09.08 00:36:52, Michael Jansen wrote:
> 
> > > So I suggest to note it down for KDE 5 and revert it for KDE 4 unless you
> > > can come up with a clever workaround for all the third party KDE
> > > applications we do not even know about.
> >
> > So, you say its better to have shortcuts in applications behave in weird
> > ways when they use QAction::setShortcut is better than them exposing a
> > clearly visible bug? I disagree completely, a visible bug is always better
> > than subtle weird behaviour thats not easily spotted - IMHO.
> 
> I agree with Ingo here. Your change would break many existing applications. 
> That just plain wrong. No it was not a bug. It worked. It was wrong usage. A 
> completely different beast.

Hmm, seems I misunderstood something. Re-Reading your last post makes clear
that there was no bug, where now there exist one.
 
> But its probably not worth to discuss it. With 865753 i committed code that 
> hopefully makes everyone happy. Old code works, shortcut schemes work and 
> developer using QAction::setShortcut get a nice little message.

Thanks, at this point I would've accepted a revert of the shortcut scheme
support as well. I was just under the impression that we just trade one
obvious against a not-so-obvious bug with that revert. Your doing a really
great job on the actions stuff there.

> For a list of your 20 kdevelop actions using QAction::setShortcut just 
> recompile kdelibs and start kdevelop. Check the output for the error messages

Thanks again.

Andreas

-- 
There is a 20% chance of tomorrow.