Decoding content-disposition-filename HTTP header

Ingo Klöcker kloecker at
Mon Sep 15 21:05:21 BST 2008

On Sunday 14 September 2008, Tom Albers wrote:
> At Sunday 14 September 2008 22:57, you wrote:
> > ok, latest news: I hacked http.cpp and added decoding function
> > statically there. so if anybody needs it in kdelibs - it can be
> > made public...
> Yeah, well, that means we have yet another location where that
> function is.
> Why not add it to KCodecs (the name is weird already) and make sure
> kmime internally uses that function? In the commit you refered to
> mhtmlthroughanalyzer.cpp, which means another copy is there? So we
> can remove that too.
> I really dislike yet another copy.


This isn't exactly trivial code and if a bug is found in one place then 
you don't really want to go look for the other 5 places to fix the same 
bug also in those places. So please add the code to KCodecs. And while 
you are at it, please also add a few unit tests for the functions.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list