Port KAnimatedSystemTray into KSystemTray

Lukas Appelhans l.appelhans at gmx.de
Mon Sep 15 12:23:07 BST 2008


Am Sonntag 14 September 2008 22:58:26 schrieb Aaron J. Seigo:
> On Sunday 14 September 2008, Lukas Appelhans wrote:
> > Ok I worked out another patch, now using QPointer and fixing all
> > objections of aseigo...
> >
> > Lukas
>
> looks good; however, this copyright notice is meaningless:
>
> Copyright (C) 2002-2007 by the Kopete developers  <kopete-devel at kde.org>
Ok I removed it...
>
> there is no "Kopete developers" legal entity.
>
> also, this line:
>
> +        delete movie;
>
> is no longer strictly needed as the move is now reparented to the
> KSystrayIcon.
True, also fixed...
>
> both minor issues .. patch looks good otherwise; i look forward to seing it
> in kdelibs =)
>
> (and i guess this is one less class in kopete, too!)
:) If there are no further objections I would like to commit this patch to 
kdelibs in a few hours then ;)

Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ksystemtray.diff
Type: text/x-patch
Size: 4674 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080915/c7ee2df1/attachment.bin>


More information about the kde-core-devel mailing list