Port KAnimatedSystemTray into KSystemTray

Aaron J. Seigo aseigo at kde.org
Sun Sep 14 21:58:26 BST 2008


On Sunday 14 September 2008, Lukas Appelhans wrote:
> Ok I worked out another patch, now using QPointer and fixing all objections
> of aseigo...
>
> Lukas

looks good; however, this copyright notice is meaningless:

Copyright (C) 2002-2007 by the Kopete developers  <kopete-devel at kde.org>

there is no "Kopete developers" legal entity.

also, this line:

+        delete movie;

is no longer strictly needed as the move is now reparented to the 
KSystrayIcon.

both minor issues .. patch looks good otherwise; i look forward to seing it in 
kdelibs =)

(and i guess this is one less class in kopete, too!)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080914/93085045/attachment.sig>


More information about the kde-core-devel mailing list