Review request for knotify osd plugin

[Ben Cooksley]

i agree, any use outside of knotify could cause big consistency
issues. extending would involve adding of widgets other than the ones
already provided. however they can work around this by rendering their
custom widget at the bottom of their image that they then set :) i
believe that would be adequate for small uses. in the future i could
see about adding a seperate bar along the bottom for more serious
uses.

therefore i now think that kosdwidget should be shipped along with the
knotify osd plugin. i will now move kosdwidget out of kdereview. as
knotify is already included in kde, should i move the knotify plugin
into kdereview like normal? ( i think i still should... just want to
be sure. )

Ben Cooksley

On 9/5/08, Aaron J. Seigo <aseigo at kde.org> wrote:
> On Thursday 04 September 2008, Ben Cooksley wrote:
>> yes, that is very handy. but it has a critical downside... it can't be
>> extended except by extending the knotify plugin.
>
> does it need to be? if so, that means that there will be apps that don't use
> it via knotify, which isn't great for reasons of consistency; what would be
> extended exactly?
>
> if there are real use cases, then that's one thing. if there are theoretical
> ones, then i'd recommend putting it in knotify until such time as an
> application actually has need to extend it and then at that point consider
> moving it to kdelibs...
>
>> also the knotify
>> plugin is completely dependant upon the library currently, all the
>> plugin does is pass it through to the library ( it doesn't actually do
>> any of the osd display work ).
>
> yes, but this doesn't matter, of course, if the OSD widget is included in
> knotify itself =)
>
>> i will fix the coding style, and if the
>
> just saw your commit =)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
>