Review request for knotify osd plugin

[Aaron J. Seigo]

On Thursday 04 September 2008, Ben Cooksley wrote:
> yes, that is very handy. but it has a critical downside... it can't be
> extended except by extending the knotify plugin.

does it need to be? if so, that means that there will be apps that don't use 
it via knotify, which isn't great for reasons of consistency; what would be 
extended exactly?

if there are real use cases, then that's one thing. if there are theoretical 
ones, then i'd recommend putting it in knotify until such time as an 
application actually has need to extend it and then at that point consider 
moving it to kdelibs...

> also the knotify
> plugin is completely dependant upon the library currently, all the
> plugin does is pass it through to the library ( it doesn't actually do
> any of the osd display work ). 

yes, but this doesn't matter, of course, if the OSD widget is included in 
knotify itself =)

> i will fix the coding style, and if the

just saw your commit =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080904/7ac71c1c/attachment.sig>